feat(webpack): support es module bundling #10788
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 742a7c3
☁️ Nx Cloud last updated this comment at |
NathanWalker
commented
Sep 1, 2025
| @@ -98,6 +180,8 @@ export default function (config: Config, env: IWebpackEnv = _env): Config { | |||
| // appears to be working - but we still have to deal with HMR | |||
| config.target('node'); | |||
|
|
|||
| // config.entry('globals').add('@nativescript/core/globals/index').end(); | |||
There was a problem hiding this comment.
This entry doesn't appear to make a difference (in commonjs or esm bundling), can probably remove.
Unless this was here for some other reason @rigor789 ?
This now works with any bundler so renaming for clarity. Also removed legacy _isModuleLoadedForUI as was no longer used.
Defaults to es module output when runtime version v9+ is detected otherwise falls back to commonjs. Allows flag `--env.commonjs` to be used anytime for explicit commonjs bundling if needed for any reason with v9+.
3c299a5 to
68832a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Projects by default would bundle to commonjs output always.
What is the new behavior?
With new v9 runtimes, es modules are natively supported.
Projects will now default to es module output when runtime version v9+ is detected otherwise falls back to commonjs. Allows flag
--env.commonjsto be used anytime for explicit commonjs bundling if needed for any reason with v9+ as well.Fully backwards compatible.