Skip to content

Fix Nightly clippy #5798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2025
Merged

Fix Nightly clippy #5798

merged 1 commit into from
Jun 6, 2025

Conversation

youknowone
Copy link
Member

@youknowone youknowone commented Jun 6, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Style
    • Updated log, error, and debug message formatting to use modern Rust named argument syntax for improved clarity and consistency. No changes to application behavior.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jun 6, 2025 •
edited
Loading

Walkthrough

The changes update string formatting in debug, trace, and error messages across several Rust modules. Old positional and debug formatting syntax is replaced with Rust's newer named formatting style using {var} and {var:?}. No logic, control flow, or public API signatures are affected; only formatting syntax is modernized for clarity and consistency.

Changes

File(s) Change Summary
compiler/codegen/src/compile.rs Updated trace, debug, and error print statements to use named formatting ({var}/{var:?})
compiler/core/src/bytecode.rs Modernized write! macro calls in Instruction::fmt_dis to use named formatting
wtf8/src/lib.rs Updated write! in fmt::Debug for Wtf8 to use named argument formatting for hex output

Poem

In fields of code, new syntax grows,
Where rabbits hop and format flows.
Named braces now, no more the old,
Our debug tales are clearly told.
With every log, a modern song—
The warren’s code is neat and strong!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 323ea3b and cb30b22.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • compiler/codegen/src/compile.rs (8 hunks)
  • compiler/core/src/bytecode.rs (1 hunks)
  • wtf8/src/lib.rs (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (11)
  • GitHub Check: Check the WASM package and demo
  • GitHub Check: Run tests under miri
  • GitHub Check: Check Rust code with rustfmt and clippy
  • GitHub Check: Run snippets and cpython tests on wasm-wasi
  • GitHub Check: Run snippets and cpython tests (macos-latest)
  • GitHub Check: Run snippets and cpython tests (ubuntu-latest)
  • GitHub Check: Run snippets and cpython tests (windows-latest)
  • GitHub Check: Run rust tests (macos-latest)
  • GitHub Check: Run rust tests (ubuntu-latest)
  • GitHub Check: Run rust tests (windows-latest)
  • GitHub Check: Ensure compilation on various targets
🔇 Additional comments (6)
wtf8/src/lib.rs (1)

679-679: LGTM! Clean formatting modernization.

The update from positional to named formatting ({:x} → {surrogate:x}) improves code readability while maintaining identical functionality.

compiler/core/src/bytecode.rs (1)

1391-1391: LGTM! Excellent formatting modernization.

The updates to named formatting syntax ({op:pad$}({code:?}): and {op:pad$}() improve code readability while preserving all functionality including the padding behavior.

Also applies to: 1396-1396

compiler/codegen/src/compile.rs (4)

154-154: Modernize compilation completion traces.
Replaced positional formatting with named arguments in the trace! calls of compile_program, compile_program_single, and compile_block_expression for consistency and clarity.

Also applies to: 169-169, 183-183

236-236: Verify InternalError formatting.
Using {r_err} here assumes InternalError implements Display in a human‐readable way. Please confirm it has a proper std::fmt::Display impl; otherwise consider using {:?} to surface the debug representation.

674-674: Modernize debug traces.
Switched to named formatting in the trace! macros within compile_statement and compile_expression to match the project's updated style guidelines.

Also applies to: 3212-3212

4435-4435: Modernize integer parsing format.
Changed format!("{}", int) to format!("{int}") in parse_big_integer to adopt named formatting and improve readability.

✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@youknowone youknowone merged commit 2e368ba into RustPython:main Jun 6, 2025
12 checks passed
@youknowone youknowone deleted the nightly-clippy branch June 6, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@youknowone