Skip to content

Add UTF-32 functions #5800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add UTF-32 functions #5800

wants to merge 1 commit into from

Conversation

youknowone
Copy link
Member

@youknowone youknowone commented Jun 6, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features

    • Added support for UTF-32 encoding and decoding functions, including standard, little-endian, big-endian, and extended decode variants.

  • Tests

    • Updated test cases to run normally by removing expected failure markers from certain string and array tests.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jun 6, 2025 •
edited
Loading

Walkthrough

The changes remove @unittest.expectedFailure decorators and related comments from two test methods, allowing them to run as normal tests. Additionally, several UTF-32 encoding and decoding functions are implemented and exposed in the _codecs Rust module, delegating their logic to corresponding Python functions.

Changes

File(s) Change Summary
Lib/test/string_tests.py Removed @unittest.expectedFailure decorator and related comment from the test_subscript method.
Lib/test/test_array.py Removed @unittest.expectedFailure decorator and related comment from the test_reverse_iterator_picking method.
vm/src/stdlib/codecs.rs Added Python-exposed functions for UTF-32 encoding/decoding variants, delegating to Python implementations.

Sequence Diagram(s)

sequenceDiagram
    participant PythonCode as Python Code
    participant Rust_Codecs as Rust _codecs module
    participant PyCodecs as _pycodecs Python module

    PythonCode->>Rust_Codecs: call utf_32_encode/decode or variants
    Rust_Codecs->>PyCodecs: delegate call to corresponding _pycodecs function
    PyCodecs-->>Rust_Codecs: return result
    Rust_Codecs-->>PythonCode: return result
Loading

Poem

In the warren where tests now hop free,
No more "expected failures" for all to see.
UTF-32 codecs join the crew,
Encoding and decoding, something new!
With every hop and every byte,
The code grows stronger, day and night.
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 323ea3b and 3c420a2.

📒 Files selected for processing (3)
  • Lib/test/string_tests.py (0 hunks)
  • Lib/test/test_array.py (0 hunks)
  • vm/src/stdlib/codecs.rs (1 hunks)
💤 Files with no reviewable changes (2)
  • Lib/test/test_array.py
  • Lib/test/string_tests.py
⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: Run snippets and cpython tests on wasm-wasi
  • GitHub Check: Run rust tests (ubuntu-latest)
  • GitHub Check: Run tests under miri
  • GitHub Check: Run snippets and cpython tests (macos-latest)
  • GitHub Check: Run snippets and cpython tests (ubuntu-latest)
🔇 Additional comments (1)
vm/src/stdlib/codecs.rs (1)

308-335: LGTM! UTF-32 codec functions correctly implemented.

The implementation perfectly mirrors the existing UTF-16 codec functions and follows all established patterns:

  • Uses the delegate_pycodecs! macro consistently to forward to Python implementations
  • Includes all necessary variants (basic, little-endian, big-endian, and extended decode)
  • Follows the correct function signature pattern with FuncArgs and VirtualMachine parameters
  • Maintains consistent naming convention (utf_32_* vs utf_16_*)
  • Properly uses #[pyfunction] attribute for Python exposure

This completes the previously missing UTF-32 codec support and aligns the codebase with standard Python codec functionality.

✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@youknowone