added mock and plain text param #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
| @@ -21,7 +21,8 @@ class ScrapeRequest(BaseModel): | |||
| }, | |||
| description="Optional headers to send with the request, including cookies " | |||
| "and user agent", | |||
| ) | |||
| ), | |||
| mock: bool = Field(default=False, description="Whether to use mock mode for the request") | |||
There was a problem hiding this comment.
Bug: Trailing Comma Causes Pydantic Field Configuration Failure
A trailing comma after the Field(...) definition for the headers field turns its assigned value into a 1-tuple (FieldInfo,). This prevents Pydantic from correctly configuring the field, leading to lost metadata and an invalid default, which can cause validation and serialization issues when headers is omitted.
VinciGit00
approved these changes
Sep 3, 2025
|
🎉 This PR is included in version 1.24.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.