Skip to content

EffOpenInventory Update #8075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: dev/feature
Choose a base branch
from
Open

EffOpenInventory Update #8075

wants to merge 6 commits into from

Conversation

Absolutionism
Copy link
Contributor

Problem

Paper has methods of opening certain InventoryTypes to players making them more reliable. Such as #openAnvil which allows actually being able to get the anvil text input of a custom anvil inventory.

Solution

Updates EffOpenInventory utilizing Papers methods (Skript 2.13 will be Paper)
Simplifies code

Testing Completed

manual

loop all inventory types:
  open loop-value to player

!broadcast anvil text input of (top inventory of player("SirSmurfy2"))

Supporting Information

Todo in the future: Support Paper's MenuTypes

Completes: #6954
Related: none

@Absolutionism Absolutionism requested a review from a team as a code owner July 23, 2025 20:28
@Absolutionism Absolutionism requested review from erenkarakal and Burbulinis and removed request for a team July 23, 2025 20:28
@Absolutionism Absolutionism added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Jul 23, 2025
@Absolutionism Absolutionism moved this to In Review in 2.13 Releases Jul 23, 2025
@TheLimeGlass
Copy link
Contributor

I'm working on #7508 that got closed after 3 weeks...
Which will support the new menu builder and keep the fixes and sections

Efnilite
Efnilite requested changes Aug 22, 2025
View reviewed changes
@Absolutionism Absolutionism requested a review from Efnilite August 22, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erenkarakal erenkarakal Awaiting requested review from erenkarakal erenkarakal is a code owner automatically assigned from SkriptLang/core-developers

@Burbulinis Burbulinis Awaiting requested review from Burbulinis Burbulinis is a code owner automatically assigned from SkriptLang/core-developers

@Efnilite Efnilite Awaiting requested review from Efnilite

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
2.13 Releases
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Absolutionism @TheLimeGlass @Efnilite @Burbulinis