Customizable Section #8110
Open
Customizable Section #8110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eSection # Conflicts: # src/main/java/ch/njol/skript/lang/SkriptParser.java
|
Labeled as draft to get feedback from others on these changes, incase any of them are extensive changes. |
sovdeeth
requested changes
Aug 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
With the introduction of
ExpressionSectionin Skript 2.10, a suggestion at the time was to make an item builder section. however there was no way to achieve such without some of the changes that are introduced in this PR. Though this broadens the usage to more than just items.Solution
Overview
This PR makes it possible to customize an object inside a section, allowing that object to be used as a default value and not require
of xfor the elements inside the section. This works by creating an object during#initthat includes the type being customized that is checked for and used within a default context. This makes it safer and easier to write expressions that rely on context, because the right type is already known and enforced.It also helps limit where default values can be used, instead of exposing all possible types through conversion, which could cause issues of confusion.
Adds
ExprSecCustomizableThis class allows the user to input any object that can contain/hold data and customize it in the section, using the respective expressions to the type being built. This does extensive checking and expression handling in
#initensuring that the provided expression can only be used as one type and to check the type is able to be customized.It is imperative that the type is determined during
#initto allow successful parsing and usage of expressions in the section, as this class can be anything.Adds
SectionEventThis class extends
Eventstoring the object being used.Hopefully to be mainstreamed to all
ExpressionSections and/orEffectSections, but some of those classes require special handling, so the current state may not be applicable.This class connects
ExpressionSections toSectionValueExpressionAdds
ExprSectionExpressionSimilar to
ExprEventExpression, this class is only used forSectionValueExpressionAdds
CustomizableRegistryThis class allows registering classes that normally cannot be customized, such as
Enums orRegistries, to be customized as another type. Example:InventoryTypetoInventory.Also includes disallowing classes/types.
Adds
DefaultCustomizablesUtility class for registering and disallowing types during the enabling process of
Skript.Misc
EventValueExpressionfor aBuilder.Testing Completed
ExprSecCustomizable.skquickTestSupporting Information
N/A
Completes: none
Related: none