Skip to content

Remove extra colon from fire resistant documentation example #8151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 28, 2025
Merged

Remove extra colon from fire resistant documentation example #8151

merged 3 commits into from
Aug 28, 2025

Conversation

arpita2525
Copy link
Contributor

This PR fixes a small documentation issue by removing an extra colon
from the "Make Fire Resistant" example in EffFireResistant.java.

Changes

  • Removed extra colon from the example: 
    - make player's tool fire resistant:
+ make player's tool fire resistant

@arpita2525 arpita2525 requested a review from a team as a code owner August 24, 2025 09:16
@arpita2525 arpita2525 requested review from cheeezburga and Burbulinis and removed request for a team August 24, 2025 09:16
@Efnilite Efnilite changed the base branch from master to dev/patch August 24, 2025 10:02
@Efnilite Efnilite linked an issue Aug 24, 2025 that may be closed by this pull request
Make fire resistant has an extra colon in docs #8148
Closed
1 task
@Efnilite Efnilite added the documentation Related to Skript's official documentation. label Aug 24, 2025
Efnilite
Efnilite requested changes Aug 24, 2025
View reviewed changes
Copy link
Member

@Efnilite Efnilite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should revert the changes made to the indentation, as tabs are used. right now you have a bunch of spaces 😉

@erenkarakal
Copy link
Member

Thank you for the pull request
Please use the dev/feature or the dev/patch branch as the base branch next time
We will let this one slide since its a very small change

@arpita2525
fix: replace spaces with tabs in indentation
6c0c03f 
fix: replace spaces with tabs across EffFireResistant.java
@arpita2525 arpita2525 force-pushed the fix-fire-resistant-doc-colon branch from 12f4e6e to 6c0c03f Compare August 24, 2025 14:07
@arpita2525
Copy link
Contributor Author

Thanks for the reviews! I’ve fixed the indentation to use tabs instead of spaces.
Also noted about using the correct dev/patch branch for future contributions.

@erenkarakal erenkarakal added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Aug 24, 2025
@sovdeeth sovdeeth merged commit 4804924 into SkriptLang:dev/patch Aug 28, 2025
5 checks passed
@skriptlang-automation skriptlang-automation bot added completed The issue has been fully resolved and the change will be in the next Skript update. and removed patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. labels Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Efnilite Efnilite Efnilite approved these changes

@erenkarakal erenkarakal erenkarakal approved these changes

@Absolutionism Absolutionism Absolutionism approved these changes

@cheeezburga cheeezburga Awaiting requested review from cheeezburga cheeezburga is a code owner automatically assigned from SkriptLang/core-developers

@Burbulinis Burbulinis Awaiting requested review from Burbulinis Burbulinis is a code owner automatically assigned from SkriptLang/core-developers

Assignees
No one assigned
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. documentation Related to Skript's official documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make fire resistant has an extra colon in docs
6 participants
@arpita2525 @erenkarakal @Efnilite @Absolutionism @sovdeeth @rpta25