Potential fix for code scanning alert no. 11: Returning stack-allocated memory #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/SolidifyDemo/ghas-vulnerable-c-cpp-template/security/code-scanning/11
To fix the issue, we need to ensure that the function never returns a pointer to stack-allocated memory. This can be achieved by dynamically allocating memory for
msg_ctxt_id
in all cases, regardless of the configuration. This way, the lifetime of the memory extends beyond the function's scope, and the returned pointer remains valid.Specifically:
msg_ctxt_id
(line 218) with a dynamically allocated buffer usingmalloc
.translation != msg_ctxt_id
).Suggested fixes powered by Copilot Autofix. Review carefully before merging.