Skip to content
This repository was archived by the owner on Oct 17, 2021. It is now read-only.

Replace find / cp with rsync #4

Draft
wants to merge 4 commits into
base: v1
Choose a base branch
from
Draft

Replace find / cp with rsync #4

wants to merge 4 commits into from

Conversation

mattt
Copy link
Contributor

@mattt mattt commented May 14, 2020

Resolves #2

rsync is more capable than the current approach of looping over find results and cp-ing files over. With this change, all files — not just ones ending in .md — are copied, and any existing files that aren't present in the specified path input are deleted.

It's unclear to me how the behavior of rsync would best be configured through the action interface. Among the options currently being considered:

  • Conditionalizing the presence of only the --delete flag with a delete input argument.
  • Allowing the user pass arbitrary options through an rsync_options input argument.

@MasterOdin MasterOdin mentioned this pull request Jun 1, 2020
Closed
@frslm
Copy link

frslm commented Jun 7, 2020 •
edited
Loading

Shouldn't docker install rsync (by just appending rsync to RUN apk add --no-cache bash findutils) for this to work?

frslm
frslm reviewed Jun 7, 2020
View reviewed changes
@Morwenn
Copy link

Morwenn commented Sep 23, 2020

I used that rsync branch for a project of mine, and it works smoothly.

The only problem I had is linked to the June comments: I expected that giving path: docs would synchronize the contents of docs with the contents of the equivalent directory in the wiki repo, but instead I had to make it path: docs/ for it to work.

Great job nonethless, that's a small but useful tool, tahnks for the great job :)

@FH-Inway
Copy link

Thanks, this branch works for me as well, see https://github.com/FH-Inway/d365fo.tools/runs/3736161296?check_suite_focus=true for a sample run. This allows us to also publish our wiki images.
Kudos to @Morwenn for pointing out the path: docs/ detail 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@frslm frslm frslm left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inserting into my workflow
4 participants
@mattt @frslm @Morwenn @FH-Inway