Skip to content

chore: suppress rawtypes in selected classes #6261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Jun 5, 2025

This PR includes rawtypes into the active compiler warnings and suppresses it for the classes causing problems.

I see the following advantages:

  • all remaining code (including potential new code) will be compiled with this warning enabled,
  • it allows to split the task of resolving all of these warnings into reasonable chunks.

If this will be merged, I will create similar pull requests for the remaining warnings, i.e. auxiliaryclass and unchecked.

Continuation of #5165.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.05%. Comparing base (27a7740) to head (8ed012e).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6261      +/-   ##
============================================
- Coverage     74.07%   74.05%   -0.02%     
+ Complexity     5351     5349       -2     
============================================
  Files           677      677              
  Lines         18648    18648              
  Branches       3621     3621              
============================================
- Hits          13813    13810       -3     
- Misses         4276     4277       +1     
- Partials        559      561       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vil02 vil02 marked this pull request as ready for review June 5, 2025 10:25
Copy link
Contributor

@alxkm alxkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It's great that this additional check is included.

@alxkm alxkm merged commit ec6f09c into TheAlgorithms:master Jun 5, 2025
6 checks passed
@vil02 vil02 deleted the supress_rawtypes_warning branch June 5, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants