Skip to content

Add Boyer-Moore string search algorithm with JUnit tests #6274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jun 11, 2025
Merged

Add Boyer-Moore string search algorithm with JUnit tests #6274

merged 20 commits into from
Jun 11, 2025

Conversation

PauLopNun
Copy link
Contributor

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.10%. Comparing base (20f0492) to head (69cab12).

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #6274      +/-   ##
============================================
+ Coverage     74.08%   74.10%   +0.02%     
- Complexity     5351     5361      +10     
============================================
  Files           677      678       +1     
  Lines         18648    18673      +25     
  Branches       3621     3627       +6     
============================================
+ Hits          13815    13838      +23     
- Misses         4275     4276       +1     
- Partials        558      559       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PauLopNun
Copy link
Contributor Author

Hi! The PR is ready, all checks are passing. Let me know if I need to implement changes.

DenizAltunkapan
DenizAltunkapan approved these changes Jun 8, 2025
View reviewed changes
Copy link
Collaborator

@DenizAltunkapan DenizAltunkapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good implementation for the bad character rule!

@PauLopNun
Copy link
Contributor Author

Looks like a good implementation for the bad character rule!

Thanks Deniz! I don't have write permissions, so could someone with access please merge it?

@DenizAltunkapan
Copy link
Collaborator

DenizAltunkapan commented Jun 8, 2025 •
edited
Loading

Looks like a good implementation for the bad character rule!

Thanks Deniz! I don't have write permissions, so could someone with access please merge it?

yess, no hurry @PauLopNun :) . @siriak will do it after he reviewed.

@PauLopNun
Copy link
Contributor Author

Looks like a good implementation for the bad character rule!

Thanks Deniz! I don't have write permissions, so could someone with access please merge it?

yess, no hurry @PauLopNun :) . @siriak will do it after he reviewed.

Okay 👍🏼, this is one of my first times contributing to open source, so I'm still getting used to the review process.

siriak
siriak approved these changes Jun 11, 2025
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak enabled auto-merge (squash) June 11, 2025 15:34
@siriak siriak merged commit 0b21bb0 into TheAlgorithms:master Jun 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak approved these changes

@DenizAltunkapan DenizAltunkapan DenizAltunkapan approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@vil02 vil02 Awaiting requested review from vil02 vil02 is a code owner

@BamaCharanChhandogi BamaCharanChhandogi Awaiting requested review from BamaCharanChhandogi BamaCharanChhandogi is a code owner

@alxkm alxkm Awaiting requested review from alxkm alxkm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PauLopNun @codecov-commenter @DenizAltunkapan @siriak