Skip to content

chore: monitor structure of the project #6291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2025

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Jun 11, 2025

The goal of this change is to make the CI fail in case when some java files are not placed in the correct location (cf. #6288).

I realize that a python script might be an overkill at the first glance. I guess writing some smart shell script is possible, but in the long run, one could easily make the suggested solution more strict (do we have a naming convention of our tests? should we have one?).

Cf. the failing log.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@vil02 vil02 force-pushed the check_project_structure branch from 8e72017 to 3c28542 Compare June 11, 2025 21:54
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.10%. Comparing base (1745d19) to head (41cd3d4).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6291   +/-   ##
=========================================
  Coverage     74.10%   74.10%           
  Complexity     5345     5345           
=========================================
  Files           677      677           
  Lines         18639    18639           
  Branches       3618     3618           
=========================================
  Hits          13812    13812           
  Misses         4272     4272           
  Partials        555      555           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vil02 vil02 force-pushed the check_project_structure branch from 3c28542 to 899ac4d Compare June 11, 2025 21:57
@vil02 vil02 force-pushed the check_project_structure branch 2 times, most recently from 02f6b32 to 8c09f75 Compare June 11, 2025 22:14
@vil02 vil02 marked this pull request as ready for review June 11, 2025 22:18
@vil02 vil02 force-pushed the check_project_structure branch from aaf8cfd to 41cd3d4 Compare June 12, 2025 14:08
@vil02 vil02 requested a review from siriak June 12, 2025 14:15
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit b427b40 into TheAlgorithms:master Jun 12, 2025
6 checks passed
@vil02 vil02 deleted the check_project_structure branch June 12, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants