Skip to content

Conversation

salmanmkc
Copy link

Upgrade to node 24 since runner release has node 24 support.

Description:
Describe your changes.

Related issue:
Add link to the related issue.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@salmanmkc salmanmkc marked this pull request as ready for review August 8, 2025 04:06
@Copilot Copilot AI review requested due to automatic review settings August 8, 2025 04:06
@salmanmkc salmanmkc requested a review from a team as a code owner August 8, 2025 04:06
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Upgrades the Node.js runtime from version 20 to version 24 for a GitHub Action, leveraging runner support for Node 24.

  • Updates Node.js runtime specification in GitHub Action configuration
  • Upgrades Node.js type definitions to match the new runtime version
  • Sets minimum Node.js engine requirement to enforce compatibility

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File Description
package.json Adds Node.js engine requirement and updates @types/node dependency
action.yml Changes GitHub Action runtime from node20 to node24
.licenses/npm/undici-types.dep.yml Updates undici-types license tracking for new version
.licenses/npm/@types/node.dep.yml Updates @types/node license tracking for new version

priya-kinthali
priya-kinthali previously approved these changes Aug 19, 2025
aparnajyothi-y
aparnajyothi-y previously approved these changes Aug 19, 2025
@priya-kinthali priya-kinthali dismissed stale reviews from aparnajyothi-y and themself via c7178f6 August 26, 2025 08:32
…advanced-usage.md

Updated GitHub Actions to use newer versions of checkout and setup-python actions.
@reneleonhardt
Copy link

Sets minimum Node.js engine requirement to enforce compatibility

Is enforcing node 24 needed for this upgrade to work?
I imagine not all popular runners install node 24 because it isn't even LTS yet (2025-10-28).
https://github.com/nodejs/release#release-schedule

@salmanmkc
Copy link
Author

salmanmkc commented Aug 26, 2025

Sets minimum Node.js engine requirement to enforce compatibility

Is enforcing node 24 needed for this upgrade to work? I imagine not all popular runners install node 24 because it isn't even LTS yet (2025-10-28). https://github.com/nodejs/release#release-schedule

Hi good question. And my apologies, I'm unsure what you mean by not all popular runners? All the hosted runners at the moment are on 2.238.0. Self-hosted runners should auto-update and if not, then they should be upgraded by the customers eventually. The thing is the actions.yml file targets node24 as well, so it should not be able to run on node 20 because of the actions.yml file.

Also this is a major bump, so we could cut a minor version before this 5.0.0 release.

@reneleonhardt
Copy link

I can only see that most developers don't update their workflows and that node 22 is the latest LTS.

https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md?plain=1#L21

Node.js 20.19.4
https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md?plain=1#L19
Node.js 20.19.4

The new ARM images should be similar (but they don't document version numbers):
https://github.com/actions/partner-runner-images/blob/main/images/arm-ubuntu-22-image.md
https://github.com/actions/partner-runner-images/blob/main/images/arm-ubuntu-24-image.md

The official runner is still based on ubuntu-22.04 (jammy)
https://github.com/actions/runner/blob/main/images/Dockerfile

Even the latest ubuntu-25.04 only ships node 20:
https://packages.ubuntu.com/search?keywords=nodejs&searchon=names&suite=plucky&section=all

So maybe it would be better not to enforce node 24 as even 2.238.0 seems to require workflow changes:

  env:
    FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true

actions/runner#3948

If possible for this change of course 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants