Skip to content

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Jul 28, 2025

highlight_color2 is now available for pixel value 0b11. Black is 0b00, white is 0b01 and highlight_color is 0b10.

Also add support for multibit values written with one command when color_command isn't provided.

tannewt added 2 commits July 28, 2025 11:49
highlight_color2 is now available for pixel value 0b11.
Black is 0b00, white is 0b01 and highlight_color is 0b10.

Also add support for multibit values written with one command when
color_command isn't provided.
@tannewt tannewt requested a review from dhalbert July 29, 2025 22:10
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks fine -- I can't test.

I will mention a suggestion I made long ago, which is to put args to the C display constructors into a struct, so we can use named arguments, use 0 as default values, etc., instead of passing dozens of arguments.

Will there ever be displays with three highlight colors? Maybe eventually it should be an array.

@dhalbert dhalbert merged commit ebd4542 into adafruit:main Jul 30, 2025
26 checks passed
@tannewt
Copy link
Member Author

tannewt commented Jul 30, 2025

Will there ever be displays with three highlight colors? Maybe eventually it should be an array.

Yup, I was thinking about this as well.

I will mention a suggestion I made long ago, which is to put args to the C display constructors into a struct, so we can use named arguments, use 0 as default values, etc., instead of passing dozens of arguments.

Do we have a separate issue for this? Claude may be able to do it.

@dhalbert
Copy link
Collaborator

Do we have a separate issue for this? Claude may be able to do it.

I finally created one: #10528.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants