Skip to content

correct board.UART() pins on Feather ESP32-S2/S3 #10537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2025

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Aug 1, 2025

also touch up some other files to be identical

Encountered by @psnt in discord, confirmed by @deshipu and @caternuson.

also touch up some other files to be identical
@dhalbert dhalbert requested a review from caternuson August 1, 2025 17:53
@caternuson
Copy link

@caternuson
Copy link

@dhalbert just to verify - the changes to mpconfigboard.mk and sdkconfig are intentional as well?

@dhalbert
Copy link
Collaborator Author

dhalbert commented Aug 1, 2025

@dhalbert just to verify - the changes to mpconfigboard.mk and sdkconfig are intentional as well?

Yes, they are intentional, to make the boards match. They are not important. I was just doing a directory compare and noticed the differences.

@dhalbert
Copy link
Collaborator Author

dhalbert commented Aug 1, 2025

These build errors are new and unrelated to the changes :(

@dhalbert
Copy link
Collaborator Author

dhalbert commented Aug 1, 2025

Tested on Feather Reverse TFT ESP32-S2 and ESP32-S3 using by doing a UART loopback and writing and reading bytes.

@caternuson
Copy link

Just pasting this here to document the general behavior the bug created:
image

Copy link

@caternuson caternuson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. Did not do any hardware testing. But change is simple and correct per schematic.

@dhalbert
Copy link
Collaborator Author

dhalbert commented Aug 1, 2025

The build error is something upstream: esptool.py v5.0.2 (first 5.x.x release) was two days ago. Other people seeing the same problem:
espressif/esptool#1107

ModuleNotFoundError: No module named 'esptool.__init__'; 'esptool' is not a package

So I'll wait a bit before re-running this.

@dhalbert
Copy link
Collaborator Author

dhalbert commented Aug 4, 2025

espressif/esptool#1107 was fixed, and a re-run was successful.

@dhalbert dhalbert merged commit 4d67ab6 into adafruit:main Aug 4, 2025
44 of 48 checks passed
@dhalbert dhalbert deleted the reverse-tft-default-uart branch August 4, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants