allow filename for mp3decoder.file property #10588
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The learn guide here: https://learn.adafruit.com/circuitpython-essentials/circuitpython-mp3-audio mentions:
And the constructor of MP3Decoder notes about the
file
argument https://docs.circuitpython.org/en/latest/shared-bindings/audiomp3/index.html#audiomp3.MP3DecoderSo the learn guide recommends to use
.file
property if you will be playing more than one different mp3 file, and the MP3Decoder constructor docs recommend to use a string instead of an open file. But currently the.file
property only allows an open file to be set, not a string with a filename.This PR updates the
.file
property to allow it to accept a string with the filename the same way that the constructor does so that both recommendations can be followed by user code.Originally noticed here: adafruit/Adafruit_CircuitPython_FruitJam#15 I will update the code there to make use of this functionality if this gets merged.