Skip to content

allow filename for mp3decoder.file property #10588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

allow filename for mp3decoder.file property #10588

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39ec280
allow filename for mp3decoder.file property
FoamyGuy Aug 27, 2025
37c5ca6
fix docs formatting
FoamyGuy Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions shared-bindings/audiomp3/MP3Decoder.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,8 @@ static void check_for_deinit(audiomp3_mp3file_obj_t *self) {
//|
// Provided by context manager helper.

//| file: typing.BinaryIO
//| """File to play back."""
//| file: Union[str, typing.BinaryIO]
//| """The name of a mp3 file (preferred) or an already opened mp3 file."""
//|
static mp_obj_t audiomp3_mp3file_obj_get_file(mp_obj_t self_in) {
audiomp3_mp3file_obj_t *self = MP_OBJ_TO_PTR(self_in);
Expand All @@ -152,6 +152,9 @@ MP_DEFINE_CONST_FUN_OBJ_1(audiomp3_mp3file_get_file_obj, audiomp3_mp3file_obj_ge
static mp_obj_t audiomp3_mp3file_obj_set_file(mp_obj_t self_in, mp_obj_t stream) {
audiomp3_mp3file_obj_t *self = MP_OBJ_TO_PTR(self_in);
check_for_deinit(self);
if (mp_obj_is_str(stream)) {
stream = mp_call_function_2(MP_OBJ_FROM_PTR(&mp_builtin_open_obj), stream, MP_ROM_QSTR(MP_QSTR_rb));
}
const mp_stream_p_t *stream_p = mp_get_stream_raise(stream, MP_STREAM_OP_READ);

if (stream_p->is_text) {
Expand Down