Skip to content

bugfix for improper error handling in TCP code. #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2025
Merged

bugfix for improper error handling in TCP code. #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d690e2e
only adjust pointers on the happy path.
anderspkd Aug 20, 2025
ad561df
remove spurious semicolon
anderspkd Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/scl/math/array.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ class Array final {
* This function will attempt to construct a \p T element using \p value, and
* then fill all slots with this value.
*/
explicit Array(int value) : Array(T{value}) {};
explicit Array(int value) : Array(T{value}) {}

/**
* @brief Copy construct an Array from another array.
Expand Down
12 changes: 6 additions & 6 deletions include/scl/net/tcp_channel.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,10 +151,10 @@ coro::Task<void> TcpChannel<SYS>::send(const Packet& packet) {
} else {
throw std::system_error(err, std::generic_category(), "send failed");
}
} else {
rem -= written;
data += written;
}

rem -= written;
data += written;
}
}

Expand All @@ -178,10 +178,10 @@ coro::Task<void> recvInto(SocketType socket,
} else {
throw std::system_error(err, std::generic_category(), "recv failed");
}
} else {
rem -= read;
dst += read;
}

rem -= read;
dst += read;
}
}

Expand Down