docs: improve docs for withComponentInputBinding
#61689
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed adev-preview for 9a381dc to: https://ng-dev-previews-fw--pr-angular-angular-61689-adev-prev-put3y9ni.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
atscott
reviewed
May 26, 2025
| </docs-step> | ||
| <docs-step title="Optional: Use a default value"> | ||
| Binded inputs can be set to `undefined` when no route elements match. | ||
| In this situation, the router will overwrite the default value of the signal input.<br> |
There was a problem hiding this comment.
I would recommend rewording this. It is not overwriting a default any more than any value “overwrites” a default. The router assigns undefined when no route information matches the key. Same as assigning undefined in a template. The default value applies when no value ever gets assigned to the input. Component input binding always binds to all inputs.
There was a problem hiding this comment.
Makes perfect sense, I'll update that.
atscott
reviewed
May 26, 2025
atscott
requested changes
Jun 4, 2025
Add mention about inputs potentially becoming `undefined`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mention about inputs potentially becoming
undefined.