fix(core): inject APP_ID before injector is destroyed
#61885
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you sure the application injector can be destroyed at this point ? |
|
Yes, I have an app which reproduces this issue. |
|
can we try to capture that in a test then ? |
|
yes, it's reproducible in existing tests in the repo, it didn't capture before because its wrapped with |
In this commit, we request `APP_ID` outside the `onDestroy` callback because the injector might already be in a destroyed state when the callback runs.
c511f0a to
6fead75
Compare
AndrewKushnir
approved these changes
Jun 10, 2025
|
Caretaker note: the presubmit is "green", this PR is ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we request
APP_IDoutside theonDestroycallback because the injector might already be in a destroyed state when the callback runs.