feat(devtools): create devtools signals view #61919
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8a32ab1 to
66ebbb2
Compare
hawkgs
reviewed
Jun 9, 2025
...ects/ng-devtools/src/lib/devtools-tabs/directive-explorer/signals-view/signal-data-source.ts
Outdated
Show resolved
Hide resolved
hawkgs
reviewed
Jun 9, 2025
...ects/ng-devtools/src/lib/devtools-tabs/directive-explorer/signals-view/signal-data-source.ts
Outdated
Show resolved
Hide resolved
hawkgs
reviewed
Jun 9, 2025
...ects/ng-devtools/src/lib/devtools-tabs/directive-explorer/signals-view/signal-data-source.ts
Outdated
Show resolved
Hide resolved
hawkgs
reviewed
Jun 9, 2025
...ects/ng-devtools/src/lib/devtools-tabs/directive-explorer/signals-view/signal-data-source.ts
Outdated
Show resolved
Hide resolved
hawkgs
reviewed
Jun 9, 2025
...s/ng-devtools/src/lib/devtools-tabs/directive-explorer/signals-view/signals-tab.component.ts
Outdated
Show resolved
Hide resolved
hawkgs
reviewed
Jun 9, 2025
...s/ng-devtools/src/lib/devtools-tabs/directive-explorer/signals-view/signals-tab.component.ts
Outdated
Show resolved
Hide resolved
hawkgs
reviewed
Jun 9, 2025
...s/ng-devtools/src/lib/devtools-tabs/directive-explorer/signals-view/signals-tab.component.ts
Show resolved
Hide resolved
hawkgs
reviewed
Jun 9, 2025
...ects/ng-devtools/src/lib/devtools-tabs/directive-explorer/signals-view/signals-visualizer.ts
Outdated
Show resolved
Hide resolved
hawkgs
reviewed
Jun 9, 2025
...ects/ng-devtools/src/lib/devtools-tabs/directive-explorer/signals-view/signals-visualizer.ts
Show resolved
Hide resolved
hawkgs
reviewed
Jun 9, 2025
...ects/ng-devtools/src/lib/devtools-tabs/directive-explorer/signals-view/signals-visualizer.ts
Show resolved
Hide resolved
hawkgs
reviewed
Jun 9, 2025
...ects/ng-devtools/src/lib/devtools-tabs/directive-explorer/signals-view/signals-visualizer.ts
Outdated
Show resolved
Hide resolved
hawkgs
reviewed
Jun 9, 2025
...ng-devtools/src/lib/devtools-tabs/directive-explorer/signals-view/signals-tab.component.html
Outdated
Show resolved
Hide resolved
hawkgs
reviewed
Jun 9, 2025
...ects/ng-devtools/src/lib/devtools-tabs/directive-explorer/signals-view/signals-visualizer.ts
Show resolved
Hide resolved
hawkgs
reviewed
Jun 9, 2025
...ects/ng-devtools/src/lib/devtools-tabs/directive-explorer/signals-view/signal-data-source.ts
Outdated
Show resolved
Hide resolved
|
Looks good! ✨ Left minor/style comments. I'll let the rest of the team to chime in. I guess this shouldn't be a blocker for moving the PR forward but can we test some of the code? I realize that it's tricky to do that for complex UI without getting into E2E but maybe we can do some unit testing of the more frictionless parts. |
hawkgs
reviewed
Jun 9, 2025
...ects/ng-devtools/src/lib/devtools-tabs/directive-explorer/signals-view/signals-visualizer.ts
Outdated
Show resolved
Hide resolved
...ng-devtools/src/lib/devtools-tabs/directive-explorer/signals-view/signals-tab.component.html
Outdated
Show resolved
Hide resolved
...ng-devtools/src/lib/devtools-tabs/directive-explorer/signals-view/signals-tab.component.html
Outdated
Show resolved
Hide resolved
hawkgs
reviewed
Jun 9, 2025
...s/ng-devtools/src/lib/devtools-tabs/directive-explorer/signals-view/signals-tab.component.ts
Outdated
Show resolved
Hide resolved
msmallest
reviewed
Jun 9, 2025
...ng-devtools/src/lib/devtools-tabs/directive-explorer/signals-view/signals-tab.component.html
Outdated
Show resolved
Hide resolved
create a component for the devtools signal pane, including view source, view value, and flashing of node updates
JeanMeche
reviewed
Jun 10, 2025
| const parsedB = parseInt(b.name, 10); | ||
|
|
||
| if (isNaN(parsedA) || isNaN(parsedB)) { | ||
| return a.name > b.name ? 1 : -1; |
There was a problem hiding this comment.
Should we do a localeCompare here instead ?
JeanMeche
reviewed
Jun 10, 2025
Comment on lines
+86
to
+88
| this.expandedData.next( | ||
| this.treeFlattener.expandFlattenedNodes(this.data.value, this.treeControl), | ||
| ); |
There was a problem hiding this comment.
This is a side effect in a map.
JeanMeche
reviewed
Jun 10, 2025
Comment on lines
+43
to
+44
| private data = new BehaviorSubject<FlatNode[]>([]); | ||
| private expandedData = new BehaviorSubject<FlatNode[]>([]); |
There was a problem hiding this comment.
Do we realy need a stream here ?
I was under the impression that a signal would fit here.
AleksanderBodurri
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create a component for the devtools signal pane, including view source, view value, and flashing of node updates
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Blocked on #61917, #61918See #60478 for a more complete demo
Does this PR introduce a breaking change?
Other information