feat(core): Add destroyed property to EnvironmentInjector
#61951
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to `DestroyRef`, this adds the `destroyed` property to `EnvironmentInjector`. It also has the ability to register callbacks with `onDestroy`, which throws if `destroyed` is already `true`. This also omits the bit about whether those callbacks have executed since I realized the property is set to `true` before executing the callbacks.
mmalerba
approved these changes
Jun 11, 2025
kirjs
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to
DestroyRef, this adds thedestroyedproperty toEnvironmentInjector. It also has the ability to register callbacks withonDestroy, which throws ifdestroyedis alreadytrue.This also omits the bit about whether those callbacks have executed since I realized the property is set to
truebefore executing the callbacks.