refactor(devtools): improve profiler recorder controls #62010
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorganize the template and reduce the vertical space taken by the controls.
JeanMeche
reviewed
Jun 11, 2025
Comment on lines
+152
to
+153
| [hidden] { | ||
| display: none !important; |
There was a problem hiding this comment.
Do we need to add this global style in this PR ? I doesn't look like the PR is introducing its usage.
There was a problem hiding this comment.
Yeah. Since tabs rely now on [hidden], I had to add this because changing the display property of a tab component (i.e. :host) overrides the default display: none by [hidden].
JeanMeche
approved these changes
Jun 11, 2025
eneajaho
reviewed
Jun 11, 2025
devtools/projects/ng-devtools/src/lib/devtools-tabs/profiler/profiler.component.html
Show resolved
Hide resolved
|
This PR was merged into the repository by commit bd3dc19. The changes were merged into the following branches: main |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
This PR will be part of a bigger effort to improve the Profiler UI/UX.
Reorganize the template and reduce the vertical space taken by the controls.