refactor(migration): support local string tokens for inject migration #62013
+38
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ae5894 to
f2c6539
Compare
The `localTypeChecker` allows us to at least support locally defined strings in addition to string literals.
f2c6539 to
6ba7462
Compare
JoostK
reviewed
Jun 12, 2025
| @@ -145,6 +145,35 @@ describe('inject migration', () => { | |||
| ]); | |||
| }); | |||
|
|
|||
| it('should account for string tokens in @Inject()', async () => { | |||
There was a problem hiding this comment.
Suggested change
| it('should account for string tokens in @Inject()', async () => { | |
| it('should account for locally declared string tokens in @Inject()', async () => { |
| @@ -885,3 +885,10 @@ function replaceParameterReferencesInInitializer( | |||
|
|
|||
| return result.join('this.'); | |||
| } | |||
|
|
|||
| function isStringType(node: ts.Expression, checker: ts.TypeChecker): boolean { | |||
There was a problem hiding this comment.
I'd add a docblock here to mention this results in false negatives for imported declarations, which we considered acceptable
|
This PR was merged into the repository by commit 4040a6b. The changes were merged into the following branches: main, 20.0.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
localTypeCheckerallows us to at least support locally defined strings in addition to string literals.Improves a bit the issue repported by #61982.