Skip to content

docs: adds --jobs 4 to Firefox release flags #62015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

docs: adds --jobs 4 to Firefox release flags #62015

wants to merge 1 commit into from
+9 −7

Conversation

dgp1130
Copy link
Contributor

@dgp1130 dgp1130 commented Jun 11, 2025 •
edited
Loading

This seems to be helpful for Mozilla reviewers to reproduce the build without encountering Bazel errors like:

Server terminated abruptly (error code: 14, error message: 'Socket closed', log file: '/home/parallels/.cache/bazel/_bazel_parallels/ae710c6507eb251f9511ac4228641059/server/jvm.out')

--local_ram_resources is also useful, but I'm not sure what to set it to by default or how necessary it is, so let's just start with --jobs 4 for now.

@dgp1130 dgp1130 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: devtools labels Jun 11, 2025
@ngbot ngbot bot modified the milestone: Backlog Jun 11, 2025
@pullapprove pullapprove bot requested a review from josephperrott June 11, 2025 20:21
@dgp1130
Copy link
Contributor Author

dgp1130 commented Jun 11, 2025

/cc @devversion

@angular-robot angular-robot bot added the area: docs Related to the documentation label Jun 11, 2025
@devversion
Copy link
Member

devversion commented Jun 11, 2025 •
edited
Loading

is there a deadline for how long the build should take? 😄 1 job could take quite a while haha

Maybe consider 2-4?

josephperrott
josephperrott approved these changes Jun 11, 2025
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgp1130
Copy link
Contributor Author

dgp1130 commented Jun 11, 2025

is there a deadline for how long the build should take? 😄 1 job could take quite a while haha

Maybe consider 2-4?

1 is definitely slow. Unfortunately I have no insight into what a reasonable set of jobs should be for Mozilla's environment or even what Bazel was inferring previously. I guess I can try --jobs 4 now and see if it causes a problem. We can only really test through trial and error and each error is a delayed DevTools release, so I'm inclined to keep things as simple as we can here.

@dgp1130
docs: adds --jobs 4 to Firefox release flags
cc98115 
This seems to be helpful for Mozilla reviewers to reproduce the build without encountering Bazel errors like:

```
Server terminated abruptly (error code: 14, error message: 'Socket closed', log file: '/home/parallels/.cache/bazel/_bazel_parallels/ae710c6507eb251f9511ac4228641059/server/jvm.out')
```

`--local_ram_resources` is also useful, but I'm not sure what to set it to by default or how necessary it is, so let's just start with `--jobs 4` for now. The 4 is arbitrary as I don't have insight into how many jobs are actually appropriate, but we can go with this for now and tweak the number later if it still causes issues.
@dgp1130 dgp1130 changed the title docs: adds --jobs 1 to Firefox release flags docs: adds --jobs 4 to Firefox release flags Jun 11, 2025
@angular-robot angular-robot bot requested a review from josephperrott June 11, 2025 22:33
josephperrott
josephperrott approved these changes Jun 11, 2025
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgp1130 dgp1130 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 12, 2025
@pkozlowski-opensource pkozlowski-opensource added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jun 12, 2025
@pkozlowski-opensource
Copy link
Member

@dgp1130 I've re-targetted it at the main branch as it wasn't merging cleanly into 20.0.x patch branch. Feel free to send a separate PR for the patch branch if needed.

@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit 38f8705.

The changes were merged into the following branches: main

@dgp1130 dgp1130 deleted the devtools-docs branch June 12, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@AleksanderBodurri AleksanderBodurri AleksanderBodurri approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: devtools area: docs Related to the documentation target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
5 participants
@dgp1130 @devversion @pkozlowski-opensource @josephperrott @AleksanderBodurri