refactor(core): update FakeNavigation to the latest spec #62017
+496
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spec updates are in whatwg/html#10919 For the most part, the updates revolve around the deferred commit handling (with precommitHandler). Updates to redirect allow more options. A committed promise now exists on the transition since commits can be delayed. Tests were made zoneless for easier debugging and timeouts were reduced.
45e41dd to
63e7890
Compare
tbondwilkinson
approved these changes
Jun 11, 2025
| @@ -457,6 +458,17 @@ export class FakeNavigation implements Navigation { | |||
| return this.disposed; | |||
| } | |||
|
|
|||
| abortTheOngoingNavigation(eventToAbort: InternalFakeNavigateEvent, reason?: Error) { | |||
There was a problem hiding this comment.
Nit: abortOngoingNavigation
I never use the in method names
| @@ -457,6 +458,17 @@ export class FakeNavigation implements Navigation { | |||
| return this.disposed; | |||
| } | |||
|
|
|||
| abortTheOngoingNavigation(eventToAbort: InternalFakeNavigateEvent, reason?: Error) { | |||
| if (!this.navigateEvent || this.navigateEvent !== eventToAbort) { | |||
There was a problem hiding this comment.
Nit: you never have to check whether navigateEvent is truthy, since comparing undefined/null to eventToAbort is always false.
Simplify to if (this.navigateEvent !== eventToAbort)
| } | ||
| const navigateerrorEvent = new Event('navigateerror', {bubbles: false, cancelable}); | ||
| const navigateerrorEvent = new Event('navigateerror', { |
There was a problem hiding this comment.
You can use the ErrorEvent constructor so you can pass error in without having to cast.
There was a problem hiding this comment.
I don’t think it exists in node nodejs/node#47587. I was getting an error trying to use it
| } | ||
| result.finishedReject(reason); | ||
| const transition = navigation.transition as InternalNavigationTransition; |
There was a problem hiding this comment.
as InternalNavigationTransition | undefined;
otherwise it looks like your ? is needless
|
TESTED=TGP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec updates are in whatwg/html#10919
For the most part, the updates revolve around the deferred commit handling (with precommitHandler). Updates to redirect allow more options. A committed promise now exists on the transition since commits can be delayed. Tests were made zoneless for easier debugging and timeouts were reduced.