Skip to content

docs: update best-practices #63132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

docs: update best-practices #63132

wants to merge 1 commit into from

Conversation

cexbrayat
Copy link
Member

@cexbrayat cexbrayat commented Aug 13, 2025 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the new behavior?

This removes the common pitfall for if blocks in the best practices, as this is no longer true in Angular v20.2, see a409534

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Linked PR in the CLI angular/angular-cli#30891

@cexbrayat
docs: update best-practices
a8e8367 
This removes the common pitfall for if blocks in the best practices, as this is no longer true in Angular v20.2, see angular/angular@a409534
@pullapprove pullapprove bot requested a review from bencodezen August 13, 2025 08:56
@angular-robot angular-robot bot added the area: docs Related to the documentation label Aug 13, 2025
@ngbot ngbot bot added this to the Backlog milestone Aug 13, 2025
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Aug 13, 2025
@alan-agius4 alan-agius4 removed the request for review from bencodezen August 13, 2025 10:26
@alan-agius4 alan-agius4 mentioned this pull request Aug 13, 2025
Merged
@atscott
Copy link
Contributor

atscott commented Aug 13, 2025

This PR was merged into the repository by commit 1269d2e.

The changes were merged into the following branches: main, 20.1.x, 20.2.x

atscott pushed a commit that referenced this pull request Aug 13, 2025
@cexbrayat @atscott
docs: update best-practices (#63132)
2c12f2a 
This removes the common pitfall for if blocks in the best practices, as this is no longer true in Angular v20.2, see a409534

PR Close #63132
atscott pushed a commit that referenced this pull request Aug 13, 2025
@cexbrayat @atscott
docs: update best-practices (#63132)
254b560 
This removes the common pitfall for if blocks in the best practices, as this is no longer true in Angular v20.2, see a409534

PR Close #63132
@atscott atscott closed this in 1269d2e Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@cexbrayat @atscott @JeanMeche