fix(compiler): error when ng-content fallback has translated children #63156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoostK
reviewed
Aug 14, 2025
packages/compiler/src/template/pipeline/src/phases/resolve_i18n_element_placeholders.ts
Outdated
Show resolved
Hide resolved
| currentOps!.i18nBlock, | ||
| pendingStructuralDirective, | ||
| ); | ||
| pendingStructuralDirective = undefined; |
There was a problem hiding this comment.
This was also copied, but I'd expect this to be irrelevant for projected views?
There was a problem hiding this comment.
I don't have the full context on it, but I think we still need it because the Projection op might not have a i18nPlaceholder in which case the pendingStructuralDirective won't have been reset further up.
There was a problem hiding this comment.
Ah, I see; I missed that it's passed into the recordTemplate* calls.
Fixes that the pipeline wasn't processing the fallback content of `ng-content` for i18n which resulted in a compiler error further down the line. Fixes angular#63065.
57cd3db to
d369df8
Compare
JoostK
approved these changes
Aug 14, 2025
|
This PR was merged into the repository by commit 5b3933f. The changes were merged into the following branches: main, 20.1.x, 20.2.x |
crisbeto
added a commit
that referenced
this pull request
Aug 15, 2025
crisbeto
added a commit
that referenced
this pull request
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that the pipeline wasn't processing the fallback content of
ng-contentfor i18n which resulted in a compiler error further down the line.Fixes #63065.