refactor(core): inline prependTokenToDependencyPath to enable tree-shaking
#63354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shaking Previously, `prependTokenToDependencyPath` was a top-level function used only in dev-mode code. ESBuild conservatively kept it in the production bundle even when `ngDevMode` was false, leaving an unnecessary stub. This commit inlines the function directly inside the `ngDevMode` guard, ensuring that ESBuild can fully remove it during tree-shaking. This eliminates dead code and reduces bundle size in production. Inlining also allows dropping `assertDefined`, which was previously referenced only inside `prependTokenToDependencyPath`. With the function now fully inlined and dev-only, `assertDefined` is also eliminated from production builds, further reducing bundle size.
|
Do you have an esbuild issue reference for why this isn't removed by tree shaking ? |
|
What if we moved |
|
Nope, I tried it :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
prependTokenToDependencyPathwas a top-level function used only in dev-mode code. ESBuild conservatively kept it in the production bundle even whenngDevModewas false, leaving an unnecessary stub.This commit inlines the function directly inside the
ngDevModeguard, ensuring that ESBuild can fully remove it during tree-shaking. This eliminates dead code and reduces bundle size in production.Inlining also allows dropping
assertDefined, which was previously referenced only insideprependTokenToDependencyPath. With the function now fully inlined and dev-only,assertDefinedis also eliminated from production builds, further reducing bundle size.This was built with production configuration and
NG_BUILD_MANGLE=0: