refactor(core): Update zone and zoneless error to be a warning instead #63457
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanMeche
approved these changes
Aug 29, 2025
JeanMeche
reviewed
Aug 29, 2025
This updates the error thrown when both `provideZoneChangeDetection` and `provideZonelessChangeDetection` are both used in the application providers to be a warning instead. The reasons for this are twofold: 1. The migration we need for using zoneless by default isn't perfect and may add `provideZoneChangeDetection` when the zoneless provider exists. This change will prevent that from causing an error 2. There might be valid situations where a "default" is used in a common provider but that can be overridden by individal applications. In tests, we do allow this type of thing, where `initTestEnvironment` may have a default but individual tests might want to use a different one. The same logic might apply to applications in some environments.
d043cdf to
2bf9861
Compare
AndrewKushnir
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the error thrown when both
provideZoneChangeDetectionandprovideZonelessChangeDetectionare both used in the application providers to be a warning instead. The reasons for this are twofold:provideZoneChangeDetectionwhen the zoneless provider exists. This change will prevent that from causing an errorinitTestEnvironmentmay have a default but individual tests might want to use a different one. The same logic might apply to applications in some environments.