Skip to content

docs(docs-infra): remove deprecated module and add test cases #63497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs(docs-infra): remove deprecated module and add test cases #63497

wants to merge 1 commit into from
+52 −4

Conversation

akib1997
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

@pullapprove pullapprove bot requested a review from josephperrott August 30, 2025 05:50
@angular-robot angular-robot bot added area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure labels Aug 30, 2025
@ngbot ngbot bot added this to the Backlog milestone Aug 30, 2025
JeanMeche
JeanMeche requested changes Sep 1, 2025
View reviewed changes
adev/src/app/core/services/content-loader.service.spec.ts

beforeEach(() => {
httpClientSpy = jasmine.createSpyObj('HttpClient', ['get']);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be using the HttpTestingController instead (and provide provideHttpClientTesting()).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeanMeche JeanMeche JeanMeche requested changes

@josephperrott josephperrott Awaiting requested review from josephperrott

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
area: docs Related to the documentation area: docs-infra Angular.dev application and infrastructure
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
2 participants
@akib1997 @JeanMeche