fix(devtools): prevent root route from being marked as active for nes… #63498
+63
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted routes Fix route detection logic to only mark root route (/) as active when URL is exactly "/"
dgp1130
reviewed
Sep 3, 2025
| @@ -65,7 +65,8 @@ function assignChildrenToParent( | |||
| const isLazy = Boolean(child.loadChildren || child.loadComponent); | |||
|
|
|||
| const pathWithoutParams = routePath.split('/:')[0]; | |||
| const isActive = currentUrl?.startsWith(pathWithoutParams); | |||
| const isActive = | |||
| routePath === '/' ? currentUrl === '/' : currentUrl?.startsWith(pathWithoutParams); | |||
There was a problem hiding this comment.
I don't think this problem is unique to /, couldn't the same thing happen if you have a route with /foo and another route at /foo/bar? In that scenario, I think visiting /foo/bar would highlight both /foo and /foo/bar.
I wonder if we should try to do a more complete match here? Not sure how complicated that would be. @AleksanderBodurri, what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: #63493
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number:
#63493
What is the new behavior?
Does this PR introduce a breaking change?