refactor(@angular/cli): add a get Zoneless/OnPush MCP tool #30868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1eedbec to
3e10340
Compare
This change adds a tool that identifies the next steps for migrating a project file or directory to Zoneless or OnPush. The priorities for migration are: 1. Find and report any unsupported uses of ZoneJS APIs. These are easily verifiable. If they exist, they need to be removed and the tool provides suggested replacements 2. Provide requirements for OnPush compatibility for any files with a Component. It is suggested to use an explicit `ChangeDetectionStrategy.Default` until it can be verified the migration is complete. The tool skips any components with explicit change detection strategy definitions. This is required since we have no way of statically verifying a component is compatible with OnPush, so we need some way to indicate the tool should move on from a component 3. When nothing is identified in the above two steps, move on to test files and suggest migrating those to use zoneless. This is the best method to verify that components are zoneless compatible.
3e10340 to
f336ca0
Compare
clydin
reviewed
Aug 20, 2025
| import { ServerNotification, ServerRequest } from '@modelcontextprotocol/sdk/types'; | ||
| import { glob } from 'fast-glob'; | ||
| import * as fs from 'fs'; | ||
| import ts from 'typescript'; |
There was a problem hiding this comment.
If the MCP server is run outside a project, typescript won't be available. This is appears to be the source for some of the CI failures. Probably would need to dynamically import within the tool itself.
|
|
||
| import { RequestHandlerExtra } from '@modelcontextprotocol/sdk/shared/protocol'; | ||
| import { ServerNotification, ServerRequest } from '@modelcontextprotocol/sdk/types'; | ||
| import { glob } from 'fast-glob'; |
There was a problem hiding this comment.
You can use import { glob } from 'node:fs/promises'; here since this is experimental (Node.js v22+ has support). Return value is slightly different but doesn't require an extra dependency.
| import { RequestHandlerExtra } from '@modelcontextprotocol/sdk/shared/protocol'; | ||
| import { ServerNotification, ServerRequest } from '@modelcontextprotocol/sdk/types'; | ||
| import { glob } from 'fast-glob'; | ||
| import * as fs from 'fs'; |
There was a problem hiding this comment.
Suggested change
| import * as fs from 'fs'; | |
| import * as fs from 'node:fs'; |
| */ | ||
|
|
||
| import { glob } from 'fast-glob'; | ||
| import * as fs from 'fs'; |
There was a problem hiding this comment.
Suggested change
| import * as fs from 'fs'; | |
| import * as fs from 'node:fs'; |
|
|
||
| import { glob } from 'fast-glob'; | ||
| import * as fs from 'fs'; | ||
| import { dirname, join } from 'path'; |
There was a problem hiding this comment.
Suggested change
| import { dirname, join } from 'path'; | |
| import { dirname, join } from 'node:path'; |
| * found in the LICENSE file at https://angular.dev/license | ||
| */ | ||
|
|
||
| import * as fs from 'fs'; |
There was a problem hiding this comment.
Suggested change
| import * as fs from 'fs'; | |
| import * as fs from 'node:fs'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a tool that identifies the next steps for migrating a project file or directory to Zoneless or OnPush. The priorities for migration are:
ChangeDetectionStrategy.Defaultuntil it can be verified the migration is complete. The tool skips any components with explicit change detection strategy definitions. This is required since we have no way of statically verifying a component is compatible with OnPush, so we need some way to indicate the tool should move on from a component