Skip to content

refactor: delete basic e2e test #30921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2025
Merged

refactor: delete basic e2e test #30921

merged 1 commit into from
Aug 14, 2025
+0 −12

Conversation

alan-agius4
Copy link
Collaborator

Protractor is private and thus this test is redundant.

@alan-agius4
refactor: delete basic e2e test
f0e554a 
Protractor is private and thus this test is redundant.
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate labels Aug 14, 2025
@alan-agius4 alan-agius4 requested a review from clydin August 14, 2025 17:58
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer action: merge The PR is ready for merge by the caretaker labels Aug 14, 2025
@ngbot
Copy link

ngbot bot commented Aug 14, 2025

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "mergeability" is failing
If you want your PR to be merged, it has to pass all the CI checks.
If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@alan-agius4 alan-agius4 merged commit 4692154 into angular:main Aug 14, 2025
34 checks passed
@alan-agius4 alan-agius4 deleted the alan-agius4-patch-1 branch August 14, 2025 18:21
@alan-agius4
Copy link
Collaborator Author

The changes were merged into the following branches: main, 20.2.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clydin clydin clydin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alan-agius4 @clydin