Skip to content

refactor(@angular/cli): improve structure of ng add command #30944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2025

Conversation

clydin
Copy link
Member

@clydin clydin commented Aug 18, 2025

The run method within the add command module exceeded recommended line limits. This commit refactors the method by extracting the logic for each Listr task into a separate private method.

The `run` method within the `add` command module exceeded recommended line limits. This commit refactors the method by extracting the logic for each Listr task into a separate private method.
@clydin clydin requested a review from alan-agius4 August 18, 2025 14:09
@clydin clydin added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Aug 18, 2025
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 19, 2025
@clydin clydin merged commit b720554 into angular:main Aug 19, 2025
34 checks passed
@clydin clydin deleted the ng-add/restructure branch August 19, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/cli target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants