-
-
Notifications
You must be signed in to change notification settings - Fork 1
Prism #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sciborrudnicki
wants to merge
91
commits into
master
Choose a base branch
from
prism
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Prism #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge with master
- Add src in each package.
- Add `ApPrismTemplate` for styling pre and code. - Add `ApPrismTemplateElement` for attributes and className. - Add `ApPrismAttributes` interface used in ApPrismTemplateElement.
Remove from npm only one level of packages directory.
- "noUnusedLocals" as true. - "noUnusedParameters" as true.
- Imported `template` and `templateSettings` from `lodash-es`. - Added property `async`, `callback`, `code`, `hooks`, `interpolation`, `codeElement`, `language`, `properties`, `ready`. - Added `highlightElement()` method to highlight code. - Updated method `interpolate()` to use imported `template` and `templateSettings`.
…ies with service, use Prism from index.d.ts.
…angeDetectorClass available features.
… because of move this feature to the next version.
…er, change PrismAClass to PrismClass.
…ponent, add jsdoc. - Add to ready set initiation of attribute and class properties. - Add properties linked to component by PROPERTIES_LINK. - Move logic from property attribute and class to service.
- Move the most logic to PrismService. - Move ChangeDetector to separate class and extend with PrismInputClass with all @input().
- Test component each property.
Added: - `attribute to test adding attributes. - className to test handling classes. - detection to test ChangeDetector. - `id` to switch between tags.
- Simplify usage information on @angular/cli. - Show how to use line-numbers plugin.
- Changed decorator @subscribe() to @apSubject(). - Set properties as optional.
…ce, change conditions.
… plugin line-numbers. - Added attribute, class properties. - Added descriptions to language, content, class, attribute. - Imported line-numbers plugin. - Used ApPrismTemplate, ApObject for attribute and class property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.