Skip to content

Conversation

ValentiWorkLearning
Copy link
Contributor

@ValentiWorkLearning ValentiWorkLearning commented May 5, 2025

Note: Please adhere to Contributing Guidelines.

Summary

I've found that while working on the custom board initial platform bringup it's a kind of:

  • make menuconfig
  • make savedefconfig
  • git add
  • git commit

When the board is configured to be out-of-tree, then it's possible to simply forget where the defconfig is stored/how to navigate into it.

Impact

Buildsystem

Testing

Just a simple make savedefconfig is enough:

"The defconfig was generated successfully at /workspaces/rtos_labs/nuttxspace/nuttx/defconfig .If you're building out-of-tree configuration, then copy it to your configuration defconfig"

@github-actions github-actions bot added Area: Tooling Area: Build system Size: XS The size of the change in this PR is very small labels May 5, 2025
@simbit18
Copy link
Contributor

simbit18 commented May 5, 2025

hi @ValentiWorkLearning replace Unix.ml with Unix.mk in the title

@ValentiWorkLearning ValentiWorkLearning changed the title Added a small usability improve for Unix.ml savedefconfig Added a small usability improve for Unix.mk savedefconfig May 5, 2025
@ValentiWorkLearning
Copy link
Contributor Author

Re-requested review just to ask, what should be done with this PR then 😄
Should I refactor it somehow or can we merge it?

@xiaoxiang781216
Copy link
Contributor

Re-requested review just to ask, what should be done with this PR then 😄 Should I refactor it somehow or can we merge it?

@anchao do you have more concern?

@acassis
Copy link
Contributor

acassis commented Jun 27, 2025

@anchao could you please review/approve ?

@jerpelea jerpelea changed the title Added a small usability improve for Unix.mk savedefconfig tool/Unix.mk: improve savedefconfig Jun 30, 2025
Copy link
Contributor

@jerpelea jerpelea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the commit title to
tool/Unix.mk: improve savedefconfig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Build system Area: Tooling Size: XS The size of the change in this PR is very small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants