Skip to content

Conversation

wangchdo
Copy link
Contributor

"tc397" is a chip name which is not appropriate to act as a board name.
the board supported here is actually "a2g-tc397-5v-tft".
The correct definition is : tricore is arch name, tc3xx is arch family
name, tc397 is chip name and the borad name is a2g-tc397-5v-tft

Note: Please adhere to Contributing Guidelines.

Summary

Correct the supported tricore tc397 board name

Impact

The supported tricore arch/arch family/chip/board will be clear

Testing

Build OK:
[ 99%] Linking C executable nuttx
/home/lixiang/downloads/cmake-3.27.1-linux-x86_64/bin/cmake -E cmake_link_script CMakeFiles/nuttx.dir/link.txt --verbose=1
/home/lixiang/tools/tricore/bin/tricore-elf-gcc -mcpu=tc39xx -mtc162 -I/home/lixiang/repos/nuttxspace/nuttx/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/Cpu/Std -I/home/lixiang/repos/nuttxspace/nuttx/arch/tricore/src/tc3xx/tc397/Libraries/Infra/Platform -I/home/lixiang/repos/nuttxspace/nuttx/arch/tricore/src/tc3xx/tc397/Configurations -Wl,--gc-sections -Wl,--cref -Wl,-Map=nuttx.map -Wl,--no-warn-rwx-segments -Xlinker -nostdlib CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Configurations/Ifx_Cfg_Ssw.c.obj CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/Asclin/Std/IfxAsclin.c.obj CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/Cpu/Std/IfxCpu.c.obj CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/Cpu/Trap/IfxCpu_Trap.c.obj CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/_Impl/IfxAsclin_cfg.c.obj CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/_Impl/IfxCif_cfg.c.obj CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/_Impl/IfxCpu_cfg.c.obj CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/_Impl/IfxPort_cfg.c.obj CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/_Impl/IfxStm_cfg.c.obj CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/_PinMap/IfxAsclin_PinMap.c.obj CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/Pms/Std/IfxPmsEvr.c.obj CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/Pms/Std/IfxPmsPm.c.obj CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/Port/Std/IfxPort.c.obj CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/Scu/Std/IfxScuCcu.c.obj CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/Scu/Std/IfxScuEru.c.obj CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/Scu/Std/IfxScuLbist.c.obj CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/Scu/Std/IfxScuRcu.c.obj CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/Scu/Std/IfxScuWdt.c.obj CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/Src/Std/IfxSrc.c.obj CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/Stm/Std/IfxStm.c.obj CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/Infra/Platform/Tricore/Compilers/CompilerTasking.c.obj CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/Infra/Ssw/TC39B/Tricore/Ifx_Ssw_Infra.c.obj CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/Infra/Ssw/TC39B/Tricore/Ifx_Ssw_Tc0.c.obj CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/Infra/Ssw/TC39B/Tricore/Ifx_Ssw_Tc1.c.obj CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/Infra/Ssw/TC39B/Tricore/Ifx_Ssw_Tc2.c.obj CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/Infra/Ssw/TC39B/Tricore/Ifx_Ssw_Tc3.c.obj CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/Infra/Ssw/TC39B/Tricore/Ifx_Ssw_Tc4.c.obj CMakeFiles/nuttx.dir/arch/tricore/src/tc3xx/tc397/Libraries/Infra/Ssw/TC39B/Tricore/Ifx_Ssw_Tc5.c.obj CMakeFiles/nuttx.dir/arch/tricore/src/common/tricore_doirq.c.obj CMakeFiles/nuttx.dir/empty.c.obj -o nuttx -mcpu=tc39xx -mtc162 -I/home/lixiang/repos/nuttxspace/nuttx/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/Cpu/Std -I/home/lixiang/repos/nuttxspace/nuttx/arch/tricore/src/tc3xx/tc397/Libraries/Infra/Platform -I/home/lixiang/repos/nuttxspace/nuttx/arch/tricore/src/tc3xx/tc397/Configurations -fno-common -Wall -Wshadow -Wundef -Os -fno-strict-aliasing -fomit-frame-pointer -ffunction-sections -fdata-sections -g -Wno-attributes -Wno-unknown-pragmas -Wstrict-prototypes -g -mcpu=tc39xx -mtc162 -I/home/lixiang/repos/nuttxspace/nuttx/arch/tricore/src/tc3xx/tc397/Libraries/iLLD/TC39B/Tricore/Cpu/Std -I/home/lixiang/repos/nuttxspace/nuttx/arch/tricore/src/tc3xx/tc397/Libraries/Infra/Platform -I/home/lixiang/repos/nuttxspace/nuttx/arch/tricore/src/tc3xx/tc397/Configurations -fno-common -Wall -Wshadow -Wundef -Os -fno-strict-aliasing -fomit-frame-pointer -ffunction-sections -fdata-sections -g -Wno-attributes -Wno-unknown-pragmas -Wstrict-prototypes -g -fdiagnostics-color=always -T Lcf_Gnuc_Tricore_Tc.lsl.tmp -Wl,--start-group arch/libarch.a binfmt/libbinfmt.a drivers/libdrivers.a fs/libfs.a libs/libc/libc.a mm/libmm.a sched/libsched.a boards/libboard.a apps/libapps.a apps/builtin/libapps_builtin.a apps/system/dd/libapps_dd.a apps/system/nsh/libapps_nsh.a apps/system/nsh/libapps_sh.a apps/testing/ostest/libapps_ostest.a apps/testing/sched/getprime/libapps_getprime.a apps/examples/hello/libapps_hello.a /home/lixiang/tools/tricore/bin/../lib/gcc/tricore-elf/11.3.1/tc162/libgcc.a /home/lixiang/tools/tricore/bin/../lib/gcc/tricore-elf/11.3.1/../../../../tricore-elf/lib/tc162/libm.a -Wl,--end-group
make[2]: 离开目录“/home/lixiang/repos/nuttxspace/output”
[ 99%] Built target nuttx
/usr/bin/make -f CMakeFiles/systemmap.dir/build.make CMakeFiles/systemmap.dir/depend
make[2]: 进入目录“/home/lixiang/repos/nuttxspace/output”
cd /home/lixiang/repos/nuttxspace/output && /home/lixiang/downloads/cmake-3.27.1-linux-x86_64/bin/cmake -E cmake_depends "Unix Makefiles" /home/lixiang/repos/nuttxspace/nuttx /home/lixiang/repos/nuttxspace/nuttx /home/lixiang/repos/nuttxspace/output /home/lixiang/repos/nuttxspace/output /home/lixiang/repos/nuttxspace/output/CMakeFiles/systemmap.dir/DependInfo.cmake "--color="
make[2]: 离开目录“/home/lixiang/repos/nuttxspace/output”
/usr/bin/make -f CMakeFiles/systemmap.dir/build.make CMakeFiles/systemmap.dir/build
make[2]: 进入目录“/home/lixiang/repos/nuttxspace/output”
[100%] Generating System.map
tricore-elf-gcc-nm nuttx | grep -v '(compiled)|($)|( [aUw] )|(..ng$)|(LASH[RL]DI)' | sort > System.map
make[2]: 离开目录“/home/lixiang/repos/nuttxspace/output”
[100%] Built target systemmap
make[1]: 离开目录“/home/lixiang/repos/nuttxspace/output”
/home/lixiang/downloads/cmake-3.27.1-linux-x86_64/bin/cmake -E cmake_progress_start /home/lixiang/repos/nuttxspace/output/CMakeFiles 0

Run OK
image

@github-actions github-actions bot added Board: tricore Size: M The size of the change in this PR is medium labels Aug 25, 2025
@wangchdo wangchdo force-pushed the rename_tricore_tc397_board branch from f73b634 to 4d5ef79 Compare August 25, 2025 05:50
anchao
anchao previously approved these changes Aug 25, 2025
@wangchdo wangchdo dismissed stale reviews from xiaoxiang781216 and anchao via 9a1597e August 25, 2025 08:10
@wangchdo wangchdo force-pushed the rename_tricore_tc397_board branch from 4d5ef79 to 9a1597e Compare August 25, 2025 08:10
Copy link
Contributor

@acassis acassis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include the board Documentation as well

@wangchdo
Copy link
Contributor Author

Please include the board Documentation as well

how to do this? is there any guidance?

@simbit18
Copy link
Contributor

Hi @wangchdo you can see here

https://nuttx.apache.org/docs/latest/contributing/documentation.html

template
https://nuttx.apache.org/docs/latest/contributing/doc_templates/board.html

@wangchdo wangchdo force-pushed the rename_tricore_tc397_board branch from 9a1597e to 2cee227 Compare August 26, 2025 03:02
@github-actions github-actions bot added Area: Documentation Improvements or additions to documentation Arch: tricore Issues related to the TriCore architecture from Infineon Size: L The size of the change in this PR is large labels Aug 26, 2025
 "tc397" is a chip name which is not appropriate to act as a board name.
 the board supported here is actually "a2g-tc397-5v-tft".
 The correct definition is : tricore is arch name, tc3xx is arch family
 name, tc397 is chip name and the borad name is a2g-tc397-5v-tft
@xiaoxiang781216 xiaoxiang781216 merged commit 2820600 into apache:master Aug 26, 2025
40 checks passed
@wangchdo wangchdo deleted the rename_tricore_tc397_board branch August 26, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arch: tricore Issues related to the TriCore architecture from Infineon Area: Documentation Improvements or additions to documentation Board: tricore Size: L The size of the change in this PR is large Size: M The size of the change in this PR is medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants