Skip to content

sched/signal: Old signal action need save sa_user #16927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2025
Merged

sched/signal: Old signal action need save sa_user #16927

merged 1 commit into from
Aug 28, 2025

Conversation

JianyuWang0623
Copy link
Contributor

Summary

Old signal action need save sa_user.
For example, set sigaction after create signalfd, the sa_sigaction was restored but sa_user not, causing signalfd_action() get the wild private data.

# create signalfd,
xxxx_main -> signalfd -> nxsig_action

# set sigaction
nsh_telnetstart -> nsh_parse -> nsh_parse_command -> nsh_execute -> nsh_builtin -> sigaction -> nxsig_action

Impact

  • sched/signal

Testing

  1. Selftest with signalfd OK.
  2. CI

@JianyuWang0623
sched/signal: Old signal action need save sa_user
21e7b42 
For example, set sigaction after create signalfd,
the sa_sigaction was restored but sa_user not,
causing signalfd_action() get the wild private data.

Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
@github-actions github-actions bot added Area: OS Components OS Components issues Size: XS The size of the change in this PR is very small labels Aug 28, 2025
@xiaoxiang781216 xiaoxiang781216 merged commit b9203c1 into apache:master Aug 28, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerpelea jerpelea jerpelea approved these changes

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

Assignees
No one assigned
Labels
Area: OS Components OS Components issues Size: XS The size of the change in this PR is very small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JianyuWang0623 @jerpelea @xiaoxiang781216