arch/arm/imxrt: Add support to both USB Controllers of iMXRT #16941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some iMXRT chips like iMXRT-1050 has two USB controllers, but until now only USB1 was supported. This patch modify the driver to support both USBs. Signed-off-by: Alan C. Assis <acassis@gmail.com>
This patch adds support to both USB controllers. Signed-off-by: Alan C. Assis <acassis@gmail.com>
Documentation/platforms/arm/imxrt/boards/arcx-socket-grid/index.rst
Outdated
Show resolved
Hide resolved
Signed-off-by: Alan C. Assis <acassis@gmail.com>
|
@xiaoxiang781216 @hartmannathan please re-review/approve |
hartmannathan
approved these changes
Sep 1, 2025
linguini1
reviewed
Sep 1, 2025
linguini1
approved these changes
Sep 1, 2025
xiaoxiang781216
approved these changes
Sep 1, 2025
|
@linguini1 that is correct, I only focused on usbhost, the usbdev I kept same way. I will work on it later |
I trust that Alan did test this as a long-time contributor, but I think in the future PRs should be held to merge until some proof of testing or explanation of what was tested is included further. I personally don't think the testing information in this PR meets what I'd expect from other contributors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some iMXRT chips like iMXRT-1050 has two USB controllers, but until
now only USB1 was supported. This patch modify the driver to support
both USBs.
Impact
Users will be able to use both USBs
Testing
arcx-socket-grid board