Scope & Purpose

When waiting synchronously on network requests, the network request should generally get the option skipScheduler=true. However, care must be taken so the network thread does not have to execute arbitrary code when resolving the response promise.

This is not done properly in many places. For example, many methods in transaction::Methods look similar to

... Methods::insert(...) {
  return insertInternal(..., MethodsApi::Synchronous)
      .waitAndGet();
}

. Without additional changes however, this means all code that happens after co_awaiting the network request might (and will usually) be executed on the network thread.

The most straightforward solutions seems to be to call .wait() on the response-future immediately after sending the request, in the case where the function was called synchronously.

• 💩 Bugfix

Checklist

• 📖 CHANGELOG entry made
• Backports
  • Backport for 3.12.0: (Please link PR)
  • Backport for 3.11: (Please link PR)
  • Backport for 3.10: (Please link PR)

Related Information

• GitHub issue / Jira ticket: https://arangodb.atlassian.net/browse/BTS-2171