Adding resource monitors to MERGE and COLLECT methods #21899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8cc0119 to
64c2c45
Compare
64c2c45 to
4f64c8e
Compare
4f64c8e to
64c2c45
Compare
… double counting, add test (must format)
…ge-resource-monitor
…ge-resource-monitor
…ge-resource-monitor
…ge-resource-monitor
…ally in the supervised buffer
…ge-resource-monitor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Adding resource monitors (specifically ResourceUsageScope) to MERGE and COLLECT methods to throw the exception when their performance exceeds a memory usage limit.
MERGE
ResourceUsageScopetoExecutorExpressionContext.increaseMemoryUsage()logic tomergeParameters()method ofObjectFunctions.cpp.aql-memory-limit.jsAqlItemBlock.COLLECT
Added
ResourceUsageScopetoSortedCollectExecutor.Added
ResourceUsageScopeto one of theAggregators.Need to add the scope to other aggregators.
Need to add testing functions of this functionality.
💩 Bugfix
🍕 New feature
🔥 Performance improvement
🔨 Refactoring/simplification
Checklist
Related Information