[BTS-1732, BTS-2177] Fix stopping the rocksdb sync thread during shutdown #21912
+55
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
A test running into a maintainer mode assertion in a commit during shutdown revealed possible races regarding the RocksDBSyncThread during shutdown.
The following changes are made in this PR:
This directly addresses BTS-1732, where the listener scheduled a task after the Scheduler was stopped.
RocksDBEngine::stop(), but its destruction was moved toRocksDBEngine::unprepare().Data structures should always be destroyed and deleted in unprepare, not in stop. This could have lead to use-after-free errors during shutdown (BTS-2177).
Checklist
Related Information