Skip to content

fix junit xml representation failures #21914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 18, 2025
Merged

fix junit xml representation failures #21914

merged 2 commits into from
Aug 18, 2025

Conversation

dothebart
Copy link
Contributor

@dothebart dothebart commented Aug 18, 2025 •
edited
Loading

Scope & Purpose

if the global scope of a testsuite fails (setup/teardown) we need to wrap a testcase as well.

originally generated XML errnously missing the testsuite tag:

<?xml version="1.0" encoding="UTF-8"?>
<testsuite errors="1" failures="96" tests="118" name="CE_shell_client__enterprise_tests_js_client_shell_hybrid-smart-graph-enterprise.js" time="4.773">
<failure>
<![CDATA[2025-08-15T14:02:13.272Z
ComplexHybridSmartGraphTraversalSuite - failed at: TypeError: getResponsibleShardFromClusterInfo is not a function - TypeError: getResponsibleShardFromClusterInfo is not a function
    at getResponsibleShard (enterprise/tests/js/client/shell/hybrid-smart-graph-enterprise.js:128:17)
    at enterprise/tests/js/client/shell/hybrid-smart-graph-enterprise.js:140:15
    at calculateNewSmartAttributeSameShard (enterprise/tests/js/client/shell/hybrid-smart-graph-enterprise.js:137:28)
..    at enterprise/tests/js/client/shell/hybrid-smart-graph-enterprise.js:2095:11
 - setUpAll failed

propper generated xml including a fabricated testcase name:

<?xml version="1.0" encoding="UTF-8"?>
<testsuite errors="1" failures="96" tests="118" name="CE_shell_client__enterprise_tests_js_client_shell_hybrid-smart-graph-enterprise.js" time="4.773">
<testcase name="whole testsuite enterprise/tests/js/client/shell/hybrid-smart-graph-enterprise.js failed">
<failure>
<![CDATA[2025-08-15T14:02:13.272Z
ComplexHybridSmartGraphTraversalSuite - failed at: TypeError: getResponsibleShardFromClusterInfo is not a function - TypeError: getResponsibleShardFromClusterInfo is not a function
    at getResponsibleShard (enterprise/tests/js/client/shell/hybrid-smart-graph-enterprise.js:128:17)
    at enterprise/tests/js/client/shell/hybrid-smart-graph-enterprise.js:140:15
    at calculateNewSmartAttributeSameShard (enterprise/tests/js/client/shell/hybrid-smart-graph-enterprise.js:137:28)
..    at enterprise/tests/js/client/shell/hybrid-smart-graph-enterprise.js:2095:11
 - setUpAll failed

found here:
https://app.circleci.com/pipelines/github/arangodb/arangodb/36964/workflows/5f079eb3-6330-4462-93a1-bb6278e0dda5/jobs/3469601/parallel-runs/2

  • 💩 Bugfix

@cla-bot cla-bot bot added the cla-signed label Aug 18, 2025
KVS85
KVS85 approved these changes Aug 18, 2025
View reviewed changes
Copy link
Contributor

@KVS85 KVS85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@KVS85 KVS85 added this to the devel milestone Aug 18, 2025
@KVS85 KVS85 merged commit 0266db4 into devel Aug 18, 2025
7 checks passed
@KVS85 KVS85 deleted the bug-fix/full-testsuite-failure-junit-representation branch August 18, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KVS85 KVS85 KVS85 approved these changes

Assignees

@dothebart dothebart

Labels
3 - Testing cla-signed
Projects
None yet
Milestone
devel
Development

Successfully merging this pull request may close these issues.
2 participants
@dothebart @KVS85