Skip to content

Update the imagePullPolicy to the correct value in configuration #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update the imagePullPolicy to the correct value in configuration #48

wants to merge 1 commit into from

Conversation

albihasani94
Copy link

@albihasani94 albihasani94 commented Sep 30, 2019 •
edited
Loading

  • values.yaml has declared the pullPolicy property
  • this value should be referred from the deployment as pullPolicy rather than imagePullPolicy

In values.yaml: pullPolicy

...
image:
  tag: latest
  pullPolicy: IfNotPresent

service:
  type: LoadBalancer
  externalPort: 80
  internalPort: 8080
  externalDebugPort: 5005
  internalDebugPort: 5005
...

In greeting-deployment.yaml: imagePullPolicy

...
spec:
      containers:
      - name: greeting
        image: {{ .Values.greeting.image }}:{{ .Values.image.tag }}
        imagePullPolicy: {{ .Values.image.imagePullPolicy }}
...

I have changed the property in greeting-deployment to:

imagePullPolicy: {{ .Values.image.pullPolicy }}

to correspond to the property declared in values.

@albihasani94
Update the imagePullPolicy to the correct value in configuration
648d275 
- values.yaml has declared the pullPolicy property
- this value should be referred from the deployment as pullPolicy rather than imagePullPolicy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@albihasani94