Fix missing "late_rule" field in WxCpCropCheckinOption deserialization #3671
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WeChat Enterprise API response for
getCropCheckinOption()
includes a "late_rule" field within the "checkindate" object, but the currentWxCpCropCheckinOption
class could not deserialize this field because several fields were missing from the data model classes.Problem
When calling
getOaService().getCropCheckinOption()
, the API returns JSON with "late_rule" data, but the response objectWxCpCropCheckinOption
could not access this information due to missing field definitions.Example API response structure that was failing:
Solution
Added missing field definitions to properly deserialize the WeChat API response:
CheckinDate class:
allow_flex
(Boolean)late_rule
(LateRule object)max_allow_arrive_early
(Integer)max_allow_arrive_late
(Integer)CheckinTime class:
time_id
,earliest_work_sec
,latest_work_sec
,earliest_off_work_sec
,latest_off_work_sec
rest_begin_time
,rest_end_time
,allow_rest
no_need_checkon
,no_need_checkoff
LateRule class:
offwork_after_time
(Integer)onwork_flex_time
(Integer)Testing
Added comprehensive tests to verify:
The changes are minimal and surgical - only adding missing field definitions without modifying any existing behavior.
Fixes #3323.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.