-
-
Notifications
You must be signed in to change notification settings - Fork 161
docs: fix missing data and use a stronger schema to catch missing errors #2806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 122 files out of 233 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is a big improvement - I kept running into issues where event/slot docs weren't being kept in sync with the code, so this should help that.
On a quick run through the code, I only saw the two things that I comment on separately, and of those, I think only the extensions issue needs to be fixed with this PR.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR focuses on enhancing type definitions and exports for a Vue.js component library to provide stronger schema validation and catch missing data. The changes improve type safety by creating comprehensive type definitions for component slots, emits, and props, while also reorganizing the codebase for better maintainability.
- Adds comprehensive type definitions for component slots, emits, and props
- Refactors type exports to include missing ComponentSlots and ComponentEmits
- Updates playground imports to use more specific import paths
- Consolidates documentation utility files and improves type safety
Reviewed Changes
Copilot reviewed 231 out of 234 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
packages/bootstrap-vue-next/src/types/index.ts | Updates exports to include ComponentSlots and ComponentEmits types |
packages/bootstrap-vue-next/src/types/ComponentSlots.ts | Adds comprehensive slot type definitions for all components |
packages/bootstrap-vue-next/src/types/ComponentEmits.ts | Adds comprehensive emit type definitions for all components |
packages/bootstrap-vue-next/src/types/ComponentProps.ts | Adds missing prop type aliases |
Multiple component .vue files | Updates to use proper type imports for slots and emits |
apps/playground/* | Updates imports to use more specific paths |
apps/docs/* | Consolidates and improves documentation utility types |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/bootstrap-vue-next/src/components/BPagination/BPagination.vue
Outdated
Show resolved
Hide resolved
…tion.vue Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Describe the PR
A clear and concise description of what the pull request does.
Small replication
A small replication or video walkthrough can help demonstrate the changes made. This is optional, but can help observe the intended changes. A mentioned issue that contains a replication also works.
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)
feat(...)
fix(...)
docs(...)
The PR fulfills these requirements:
CHANGELOG
is generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied