-
Notifications
You must be signed in to change notification settings - Fork 980
fix(site): exclude workspace schedule settings for prebuilt workspaces #18826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
95ca5f7
207c80f
450b3e1
0bde254
73f5476
f306854
d5e45bb
0120c5b
ad475cf
02c0ff5
1260e49
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd suggest adding a story here to showcase the new behaviour. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good catch! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Addressed in 73f5476 |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nonblocking thoughts:
isPrebuilt
instead ofisPrebuilt
. I know is a small and subtle naming change but a Prebuild is not the same thing as a prebuilt workspace.prebuilds.IsUnclaimedPrebuiltWorkspace(...)
function to encapsulate and abstract this logic?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way I have been using these terms, is
Prebuild
=Prebuilt Workspace
, but maybe I have been using it wrong. What is the difference between Prebuild and Prebuilt Workspace?Added a comment in 0bde254, let me know if it works.
Yes, we can do that and reuse it in other parts of the code that already have this logic. I can address it in a separate PR.Edit: actually, there is a better solution that I completely forgot 🤦♀️ which is to useworkspace.IsPrebuild()
. This encapsulates that logic onworkspace
and improves readability: 0120c5bI will create a follow up PR to add some tests to test this parameter.