Skip to content

fix(agent/agentcontainers): fix TestAPI/NoUpdaterLoopLogspam flake #18905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 17, 2025
Merged

fix(agent/agentcontainers): fix TestAPI/NoUpdaterLoopLogspam flake #18905

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
271e4c2
fix(agent/agentcontainers): fix `TestAPI/NoUpdaterLoopLogspam` flake
DanielleMaywood Jul 16, 2025
e415299
chore: comment
DanielleMaywood Jul 16, 2025
ba49527
fix: typo
DanielleMaywood Jul 17, 2025
5bb2756
chore: waitNext is more common with the watcher
DanielleMaywood Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: comment
  • Loading branch information
@DanielleMaywood
DanielleMaywood committed Jul 16, 2025
commit e4152993eac6b73bbaf132b3cf71f97841b05d51
6 changes: 3 additions & 3 deletions agent/agentcontainers/api_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,9 +369,9 @@ func TestAPI(t *testing.T) {
api.Start()
defer api.Close()

// Wait for the watcher to have initialized. As the
// watcher logs, it can interfere with the test and
// cause a flake.
// The watcherLoop writes a log when it is initialized.
// We want to ensure this has happened before we start
// the test so that it does not intefere.
testutil.RequireReceive(ctx, t, fWatcher.nextCalled)

// Make sure the ticker function has been registered
Expand Down
Loading