Skip to content

feat: add preset selector in TasksPage #19012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jul 24, 2025
Merged

feat: add preset selector in TasksPage #19012

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
a4ccb41
feat: add preset selector in TasksPage
johnstcn Jul 23, 2025
8cafbc9
sort presets with default at top
johnstcn Jul 24, 2025
071c896
add labels for template and preset selectors
johnstcn Jul 24, 2025
9938038
increase template and preset select width
johnstcn Jul 24, 2025
ec3d72d
override ai prompt with preset if defined
johnstcn Jul 24, 2025
31901f9
hide presets selector if no presets exist for template
johnstcn Jul 24, 2025
c4dbd2f
fix ai prompt parameter name
johnstcn Jul 24, 2025
72db7b6
update storybook
johnstcn Jul 24, 2025
4f2d820
address copilot comments
johnstcn Jul 24, 2025
7602ef6
address code review comments
johnstcn Jul 24, 2025
80b96de
fix crash if presets is null
johnstcn Jul 24, 2025
e248c14
adjust label styling
johnstcn Jul 24, 2025
bf6f113
correctly handle selecting default preset on presetData change
johnstcn Jul 24, 2025
b3916e2
DesiredPrebuildInstances
johnstcn Jul 24, 2025
0fd55e2
add label to indicate if prompt is defined by preset
johnstcn Jul 24, 2025
9da9f5d
use preexisting query
johnstcn Jul 24, 2025
2680111
keep form label around
johnstcn Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
override ai prompt with preset if defined
  • Loading branch information
@johnstcn
johnstcn committed Jul 24, 2025
commit ec3d72d9f7386e03b7e17f29bda8853872cd0e51
16 changes: 13 additions & 3 deletions site/src/pages/TasksPage/TasksPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,13 @@ const TaskForm: FC<TaskFormProps> = ({ templates, onSuccess }) => {
const selectedTemplate = templates.find(
(t) => t.id === selectedTemplateId,
) as Template;

// Extract AI prompt from selected preset
const selectedPreset = presets?.find((p) => p.ID === selectedPresetId);
const presetAIPrompt = selectedPreset?.Parameters.find(
(param) => param.Name === "ai_prompt",
)?.Value;
const isPromptReadOnly = !!presetAIPrompt;
const {
externalAuth,
externalAuthError,
Expand Down Expand Up @@ -291,8 +298,7 @@ const TaskForm: FC<TaskFormProps> = ({ templates, onSuccess }) => {

const form = e.currentTarget;
const formData = new FormData(form);
const prompt = formData.get("prompt") as string;
const templateID = formData.get("templateID") as string;
const prompt = presetAIPrompt || (formData.get("prompt") as string);

try {
await createTaskMutation.mutateAsync({
Expand Down Expand Up @@ -326,9 +332,13 @@ const TaskForm: FC<TaskFormProps> = ({ templates, onSuccess }) => {
required
id="prompt"
name="prompt"
value={presetAIPrompt || undefined}
readOnly={isPromptReadOnly}
placeholder={textareaPlaceholder}
className={`border-0 resize-none w-full h-full bg-transparent rounded-lg outline-none flex min-h-[60px]
text-sm shadow-sm text-content-primary placeholder:text-content-secondary md:text-sm`}
text-sm shadow-sm text-content-primary placeholder:text-content-secondary md:text-sm ${
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this could be done later but it can be confusing for users that the Prompt is disabled because of a preset. In the dynamic parameters create workspace page, I label parameters when they are preset as such so user know why they can't be edited.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could add a quick tooltip here

Copy link
Member Author

@johnstcn johnstcn Jul 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 0fd55e2

isPromptReadOnly ? "opacity-60 cursor-not-allowed" : ""
}`}
/>
<div className="flex items-center justify-between pt-2">
<div className="flex items-center gap-4">
Expand Down